Skip to content

Inherit genie config from genie_beam_settings.fcl in sbncode#667

Merged
bear-is-asleep merged 3 commits into
developfrom
feature/mdeltutt_genie_base_settings
Apr 1, 2025
Merged

Inherit genie config from genie_beam_settings.fcl in sbncode#667
bear-is-asleep merged 3 commits into
developfrom
feature/mdeltutt_genie_base_settings

Conversation

@marcodeltutto
Copy link
Copy Markdown
Member

@marcodeltutto marcodeltutto commented Feb 26, 2025 •
edited
Loading

Description

sbncode PR SBNSoftware/sbncode#492 introduces a common genie settings file to be used across SBN. With this PR, SBND inherits the GENIE configuration from it.

Fixes #588.

Running fhicl-dump on prodgenie_corsika_proton_rockbox_sbnd.fcl gives the following differences:

New Original Comment
BeamCenter: [0,0,0] BeamCenter: [-1400, -350, 0] Good to change, used if we had a histogram-based flux
N/A BeamRadius: 3 Good to change, used if we had a histogram-based flux
DefinedVtxHistRange: false DefinedVtxHistRange: true Good to change, used if we had a histogram-based flux
N/A EventsPerSpill: 0 Same as 0, OK
GHepPrintLevel: -1 N/A OK, -1 is no print
N/A MonoEnergy: 2 OK, we should not set options for FluxType = "mono"
SpillTimeConfig: "\n evgb::EvtTimeFNALBeam booster\n nperbatch 84\n nfilled 81\n intensity 1.0\n dtbucket 18.936\n sigma 1.308\n global 0.0\n " SpillTimeConfig: "evgb::EvtTimeFNALBeam booster, dtbucket=18.936, sigma=1.308" OK, as nperbatch 84 nfilled 81 intensity 1.0 are defaults
N/A RandomTimeOffset: 10000 OK
N/A SurroundingMass: 0 OK, we shouldn't set this, it's for fluxes that don't know pot normalization
VtxPosHistRange: [] VtxPosHistRange: [-210, 210, -210, 210, 10, 510] Good to change, used if we had a histogram-based flux

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer. No
  • Does this affect the standard workflow? Yes

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@marcodeltutto marcodeltutto added enhancement New feature or request simulation genie or geant4 (g4) labels Feb 26, 2025
@marcodeltutto marcodeltutto self-assigned this Feb 26, 2025
@marcodeltutto marcodeltutto force-pushed the feature/mdeltutt_genie_base_settings branch from e10a73d to 02b0a94 Compare March 20, 2025 15:21
@marcodeltutto marcodeltutto marked this pull request as ready for review March 20, 2025 15:21
@marcodeltutto marcodeltutto force-pushed the feature/mdeltutt_genie_base_settings branch from 02b0a94 to b5cda3a Compare March 21, 2025 14:46
@bear-is-asleep
Copy link
Copy Markdown
Contributor

bear-is-asleep commented Mar 25, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Copy Markdown
Member Author

marcodeltutto commented Mar 25, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 25, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Copy Markdown
Member Author

marcodeltutto commented Mar 25, 2025

I think the ref files may need to be re-generated again as it's picking up changes in older PRs. In any case, the changes on the GENIE config shown in the fcl checks are expected.

@bear-is-asleep
Copy link
Copy Markdown
Contributor

bear-is-asleep commented Mar 26, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Copy Markdown
Member Author

marcodeltutto commented Mar 27, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Mar 27, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@marcodeltutto
Copy link
Copy Markdown
Member Author

marcodeltutto commented Mar 27, 2025

Thanks @bear-is-asleep, I was actually able to spot one missing line, which I fixed the last commit. I think the CI output looks as expected.

There is a difference in masked channels in detsim output that is not related to this PR, I also see it in other PRs.

@bear-is-asleep bear-is-asleep moved this from Todo to To be Merged (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep
Copy link
Copy Markdown
Contributor

bear-is-asleep commented Mar 27, 2025

Approved

@bear-is-asleep bear-is-asleep moved this from To be Merged (RM only) to Approved (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep bear-is-asleep merged commit 5f5b40c into develop Apr 1, 2025
@bear-is-asleep bear-is-asleep moved this from Approved (RM only) to In tagged release in SBND March 2025 production Apr 1, 2025
@marcodeltutto marcodeltutto mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bear-is-asleep bear-is-asleep bear-is-asleep approved these changes

@jzennamo jzennamo Awaiting requested review from jzennamo

Assignees

@marcodeltutto marcodeltutto

Labels

enhancement New feature or request simulation genie or geant4 (g4)

Projects

SBND March 2025 production
Status: In tagged release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Base GENIE Gen FHiCL from sbncode

3 participants

@marcodeltutto @bear-is-asleep @FNALbuild